Skip to content

feat: add Connector docs to LB4 docs#863

Merged
hacksparrow merged 1 commit into
gh-pagesfrom
feat/lb4-connector-docs
Jul 31, 2019
Merged

feat: add Connector docs to LB4 docs#863
hacksparrow merged 1 commit into
gh-pagesfrom
feat/lb4-connector-docs

Conversation

@hacksparrow

Copy link
Copy Markdown
Contributor

Add Connector docs to LB4 docs.

Required to fix loopbackio/loopback-next#2598.

Comment thread package-lock.json Outdated

@b-admike b-admike left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Do we need to copy the files in update-readmes.sh again though since we are doing it in the update-lb4-docs.js script?

@raymondfeng

Copy link
Copy Markdown
Contributor

@hacksparrow

Copy link
Copy Markdown
Contributor Author

@b-admike

Nice. Do we need to copy the files in update-readmes.sh again though since we are doing it in the update-lb4-docs.js script?

They are working on different set of files:

  • update-readmes.sh -> README files specifically from external repos
  • update-lb4-docs.js -> Doc files which already exists in the lb3 dir

@hacksparrow
hacksparrow force-pushed the feat/lb4-connector-docs branch from 2f7de96 to 92e179a Compare July 31, 2019 15:53

@jannyHou jannyHou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread update-readmes.sh
# from the given github repo. If that branch is NOT master, then the
# branch name will be appended to the local readme file name.
(cat <<LIST_END
strongloop loopback-connector-mysql master

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: strongloop loopback-connector-couchdb2 master is also supported

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add it after this one lands.

Add Connector docs to LB4 docs
@hacksparrow
hacksparrow force-pushed the feat/lb4-connector-docs branch from 92e179a to 2c7e2ac Compare July 31, 2019 16:04
@hacksparrow
hacksparrow merged commit 2c7e2ac into gh-pages Jul 31, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the feat/lb4-connector-docs branch July 31, 2019 16:13
@hacksparrow
hacksparrow temporarily deployed to github-pages July 31, 2019 16:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "Connectors Reference" docs pages to LB4 docs

6 participants